environment.yml: handle variant and newer condas better #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nel-priority to handle if user/distro has set it to something else
|
Actually channel_priority cannot be set in environment.yml; I misread some docs. Removed that bit. |
|
Yes, I confirmed this works for me with Miniforge on Windows, so no need to install tensorflow separately after installing everything else from conda-forge. Also, it seems that Miniforge at least defaults to flexible channel priority, so that shouldn't be a problem (I think that's by far the most popular distribution that doesn't include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be smarter about alternate builds of conda, set channel-priority to handle if user/distro has set it to something else.
This is an attempt to improve on the install issues seen with #1332
Note that the
channel_priority: truemay seem wrong, but it's a ternary value, with false meaning disabled, true meaning flexible, and strict (a new value) meaning strict. We don't want strict, at least as long as we need tensorflow on Windows. Flexible should do the job.