Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the first build guide #423

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

bbhtt
Copy link
Collaborator

@bbhtt bbhtt commented Dec 16, 2023

Addresses most of the things in #230, so closes #230

This simplifies the first build guides and reduces possible failure points.

  • script is self-contained in the manifest
  • build and install instructions combined to avoid running multiple commands
  • Add --install-deps-from to avoid figuring out installing runtimes
  • Removes creating a repo - not sure why this is in a hello world guide. Exporting it to a repo has no direct use cases since it can be installed with flatpak-builder directly and the section references more complicated topics such as appdata files, build-update, gpg-verify etc. that need not be in a hello world guide.

So I replaced it with sharing a single file bundle, which seems to be more useful in a hello world situation.

@TingPing
Copy link
Member

TingPing commented Jan 4, 2024

Add --install-deps-from to avoid figuring out installing runtimes

There is a small gotcha here. If they follow the website to add Flathub it will be added as a system repository and --user --install-deps-from=flathub will fail.

docs/first-build.rst Outdated Show resolved Hide resolved
@bbhtt
Copy link
Collaborator Author

bbhtt commented Jan 5, 2024

Add --install-deps-from to avoid figuring out installing runtimes

There is a small gotcha here. If they follow the website to add Flathub it will be added as a system repository and --user --install-deps-from=flathub will fail.

I mentioned the command to remote-add --user in the top lines 7-11. To be honest, I think the website should recommend --user

@bbhtt
Copy link
Collaborator Author

bbhtt commented Jul 2, 2024

I think it's good enough right now to land as it solves a bunch of issues.

Installing the remote is explicitly mentioned as a step, so I hope no one will skip that.

@bbhtt bbhtt merged commit c3eadc8 into flatpak:master Jul 2, 2024
3 checks passed
@bbhtt bbhtt deleted the fix-first-build branch July 2, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building your first Flatpak doesn't work
2 participants