common: Add thread safety on libcurl usage #5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanonyme
reviewed
Aug 16, 2022
There can happen a race condition between internal libcurl structure content when two threads set the `data` structure for the callbacks from two threads, which can cause access of already freed stack-allocated `data`, resulting in a memory corruption. Closes flatpak#3701
mcrha
force-pushed
the
wip/thread-safety-with-libcurl
branch
from
99e396c
to
0030d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can happen a race condition between internal libcurl structure
content when two threads set the
datastructure for the callbacksfrom two threads, which can cause access of already freed stack-allocated
data, resulting in a memory corruption.Closes #3701
An alternative solution, which can run requests in parallel, would be to create a new
FlatpakHttpSessionfor every request. It seems to be a cheap structure, both for libcurl and for libsoup, but I'm not that used to those structures, thus I cannot tell for sure. I can change the commit to do that instead, if needed.