Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent remote desktop sessions #1004

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Persistent remote desktop sessions #1004

merged 11 commits into from
Jul 13, 2023

Commits on Jul 13, 2023

  1. screen-cast: Move out persistence related functionality 

    This makes it reusable for a future remote-desktop variant.
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    dfda40f View commit details
    Browse the repository at this point in the history

  2. data/remote-desktop: Fix typo in documentation 

    The available devices lists available devices, not sources.
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e471246 View commit details
    Browse the repository at this point in the history

  3. data/impl/screen-cast: Remove bogus method arg from docs 

    session_id is passed elsewhere.
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d251095 View commit details
    Browse the repository at this point in the history

  4. data/impl/remote-desktop: Add missing docs for SelectDevices

    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    0a462d0 View commit details
    Browse the repository at this point in the history

  5. data/impl/screen-cast: Fix docs for communicating restore data 

    Nothing related to persistence will be communicated via the
SelectSources response signal, it's all sent via the response signal to
the Start method.
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a9f090c View commit details
    Browse the repository at this point in the history

  6. data/impl/remote-desktop: Document props in the start response 

    Document "streams" equivalent to the response signal for starting a
screen cast session, and the selected device types.
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2586ecf View commit details
    Browse the repository at this point in the history

  7. screen-cast: Fix source type validation function name 

    Copy paste error from the remote desktop portal.
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fdc7c0d View commit details
    Browse the repository at this point in the history

  8. screen-cast: Move out helper checking variant dict key existance

    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    74c7d5d View commit details
    Browse the repository at this point in the history

  9. remote-desktop: Add persistent sessions 

    This adds persistent remote desktop sessions similar to persistent
screen cast sessions. What it means is that applications can ask for
sessions to be "saved" either temporarily in the portal, or in the
permission store, and later be restored at will, without any interactive
dialog showing up.

It works the same way, by the Start() method returning a restore token,
and similarly to the screen cast variant, passing the same restore token
to the SelectDevices() method the next time.

Closes: flatpak#850
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e6f7765 View commit details
    Browse the repository at this point in the history

  10. session: Add an 'internal-closed' signal 

    This will be emitted unconditionally, so that auxiliary session
functionality can clean up things when the session closes.
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a64d44a View commit details
    Browse the repository at this point in the history

  11. restore-token: Namespace API under xdp_session_persistence_*() 

    This means all methods take a session that already carries some relevant
information, e.g. D-Bus peer name, and app ID. It also means transient
permission handling can be hooked up to the 'internal-closed' signal
instead of being handled manually.
    @jadahl
    jadahl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e80eee5 View commit details
    Browse the repository at this point in the history