Status pages for Search and backend improvements #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bugs in both windows as well :)
turtlegarden
commented
Nov 11, 2023
src/downgrade.blp
Outdated
There was a problem hiding this comment.
The blueprint files' changes are mostly formatting, so I will point out the specific changes made
src/orphans.blp
Outdated
| title: _("No Leftover Data"); | ||
| description: _("There is no leftover user data"); | ||
| } | ||
| template $OrphansWindow : Adw.Window { |
| description: _("There is no leftover user data"); | ||
| } | ||
|
|
||
| Adw.StatusPage no_results { |
There was a problem hiding this comment.
Add no_results status page
| [start] | ||
| SearchEntry search_entry { | ||
| hexpand: true; | ||
| placeholder-text: _("Search for Flatpaks…"); |
There was a problem hiding this comment.
Change placeholder text
| } | ||
|
|
||
| [start] | ||
| MenuButton remotes_dropdown { |
There was a problem hiding this comment.
This dropdown looks strange on my end
There was a problem hiding this comment.
It will probably be removed, I'm not very happy with the structure of the Search Install window myself. So that whole window is most likely going to be reworked.
| @@ -1,8 +1,7 @@ | |||
| using Gtk 4.0; | |||
| using Adw 1; | |||
|
|
|||
| template WarehouseWindow : Adw.ApplicationWindow { | |||
| styles["devel"] | |||
| template $WarehouseWindow: Adw.ApplicationWindow { | |||
There was a problem hiding this comment.
Update syntax and remove hard-coded devel
| Adw.Clamp{ | ||
| search-mode-enabled: bind search_button.active bidirectional; | ||
| key-capture-widget: main_toolbar_view; | ||
|
|
| Adw.StatusPage no_flatpaks { | ||
| icon-name: "error-symbolic"; | ||
| title: _("No Flatpaks Found"); | ||
| description: _("There are either no Flatpaks that match the current filter, Warehouse cannot see the list of installed Flatpaks, or the system has no Flatpaks installed."); | ||
| } | ||
|
|
||
| Adw.StatusPage no_results { |
There was a problem hiding this comment.
no_results status page
turtlegarden
changed the title
|
I think it's ready to be merged now. Waiting on approval |
turtlegarden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important!
After merging, please update the PO files! This contains new localized strings, and my computer cannot compile Blueprint localizations!
Main Content
This pull request adds a troubleshooting string to the
AdwAboutWindowof Warehouse containing various informations about the system and app version. Feel free to suggest more things to add to the string, I was modeling it off this debug info screen:This pull request also adds a catch clause for creation of rows, so that in Flatpak installations without many flatpaks (like a GNOME Builder environment) Warehouse can be launched.
Other features included:
blueprint-compiler formatrun on all Blueprint files