fix Group Layer Options constructor wrong nullability #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpryan
added a commit
that referenced
this pull request
Jun 4, 2021
* Add actions/stale@v3 GitHub Action patched version * updated to latest master version * updated dependcies to compile again * updated latlong import * migrated to unsound null safety * removed .packages from repository * small fixes * Update lib/src/core/point.dart Co-authored-by: Sata51 <vm.mathieu@gmail.com> * Update pubspec.yaml Co-authored-by: Sata51 <vm.mathieu@gmail.com> * Update lib/src/gestures/latlng_tween.dart Co-authored-by: Sata51 <vm.mathieu@gmail.com> * type '_ControllerStream<LatLng?>' is not a subtype of type 'Stream<LatLng>' of 'stream' * changes according to review * made key nullable * made rebuild nullable again * Fix polyline border drawing * corrected typo in dependency_overrides * Removed unnecessary null-checks * Limit number of purges in TileLayer and cancel pending on dispose * Fix error messages in mocked classes * Set ready to true always (state is never null) * make bounds, getBounds and getCenter null safe * use http.RetryClient instead of flutter_image * formatting * add change notes * Added example page for NetworkTileProvider * Added dependency on null safe version 0.17.0 of package intl (would not build without it) * Changed to master branch of flutter_image that is now null-safe * Change override of package flutter_image to new location in flutter packages * Update git repo link * Fix typos * Sort dependencies * Reformat and improve pub score * Upgraded to flutter_image ^4.0.1 * Reformatted files to standard settings * Reformatted crs.dart that wasn't changed using command line * Random Fixes Everywhere (#910) * Update git repo link * Fix typos * Sort dependencies * Improve pub score * remove TODO * Clarification of all options available for offline mapping (#913) * Update README.md - Clarified all options for offline mapping - Fixed some capitalisation inconsistencies. * Update README.md * fix Group Layer Options constructor wrong nullability (#921) Co-authored-by: 6y <tlserver6y@gmail.com> * null check regex in template() * re-apply #913 into null safety branch * Review comments from issues/829-nullsafety (#919) * fix: remove deprecated properties Removes deprecated properties, updates documentation and changed bounds getCenter to a getter. * fix: simplify center getter * docs: improve documentation for NetworkTileProvider * docs: update documentation for tileProvider * dart format * make urlTemplate required, make throttleSTreamTransformerWithTrailingCall updateInterval required. * use late final where possible * revert making urlTemplate non-nullable Co-authored-by: John Ryan <ryjohn@google.com> Co-authored-by: escamoteur <github@burkharts.net> Co-authored-by: Sata51 <vm.mathieu@gmail.com> Co-authored-by: alt <ali.tazik@gmail.com> Co-authored-by: Ahmed-gubara <ahmed.gubara93@gmail.com> Co-authored-by: josxha <34318751+josxha@users.noreply.github.com> Co-authored-by: Nico Mexis <nico.mexis@kabelmail.de> Co-authored-by: Luka S <58115698+JaffaKetchup@users.noreply.github.com> Co-authored-by: 6y <tlserver@yahoo.com> Co-authored-by: 6y <tlserver6y@gmail.com> Co-authored-by: André Andersson <andre.andersson@zenon.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other
LayerOptionsconstructor accept null key and null rebuild,GroupLayerOptionsshould also accept.