This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #433.
Before, all tasks were attempting to rotate the provider list and update the cache with their updated version.
This resulted in this pattern for example:
Requests to providers are not evenly distributed when receiving bursts. This PR adds time sharing so that each provider gets a time slot and thus a fair chance to provide. This results in a more stable implementation of round robin
Demo
No regression. Performance is still the same. Running with
tower-http=0.3.5
because of #436.Before
After
Notes
Checklist
I have made corresponding changes to the testsI have made corresponding changes to the documentation