Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fleet can fail to start in some MDM configured states #18558

Closed
xpkoala opened this issue Apr 26, 2024 · 1 comment
Closed

Fleet can fail to start in some MDM configured states #18558

xpkoala opened this issue Apr 26, 2024 · 1 comment
Assignees
@roperzh
Labels
~backend Backend-related issue. bug Something isn't working as documented ~critical bug This is a critical bug and may require a patch release. #g-mdm MDM product group P0 Prioritize as emergency :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Milestone
4.49.1

Comments

@xpkoala
Copy link
Contributor

xpkoala commented Apr 26, 2024 •
edited
Loading

Fleet version: 4.49.0

Web browser and operating system: NA

💥  Actual behavior

If MDM has ever enabled on a Fleet server and then the server environment variables are no longer set, Fleet will fail to start.

🧑‍💻  Steps to reproduce Scenario 1

  1. Upon starting a fresh Fleet instance
  2. Set the MDM environment variables for the server
  3. Enable MDM via the integrations page
  4. Shut down the server
  5. Remove the MDM environment variables for the server
  6. Start the server

Steps to reproduce Scenario 2

  1. Upon starting a fresh Fleet instance
  2. Set the Windows MDM environment variables for the server
  3. Enable MDM via the integrations page
  4. Shut down the server
  5. Start the server

🕯️ More info (optional)

Internal thread where this was discovered by @rfairburn https://fleetdm.slack.com/archives/C019WG4GH0A/p1714102717866679
@xpkoala xpkoala added bug Something isn't working as documented :reproduce Involves documenting reproduction steps in the issue #g-mdm MDM product group ~critical bug This is a critical bug and may require a patch release. :incoming New issue in triage process. P0 Prioritize as emergency labels Apr 26, 2024
@xpkoala xpkoala added the ~backend Backend-related issue. label Apr 26, 2024
@xpkoala xpkoala changed the title Server Fleet will not start when Windows MDM is enabled and Mac MDM is disabled Fleet can fail to start when MDM is misconfigured Apr 26, 2024
@lukeheath lukeheath added the :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. label Apr 26, 2024
roperzh added a commit that referenced this issue Apr 26, 2024
@roperzh
fixed a bug causing servers with Windows MDM only to crash
6c7c2a2 
for #18558
@roperzh roperzh mentioned this issue Apr 26, 2024
Merged
4 tasks
@roperzh roperzh self-assigned this Apr 26, 2024
@roperzh roperzh removed :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. labels Apr 26, 2024
@georgekarrv georgekarrv added this to the 4.49.1 milestone Apr 26, 2024
@xpkoala xpkoala changed the title Fleet can fail to start when MDM is misconfigured Fleet can fail to start in some MDM configured states Apr 26, 2024
@xpkoala xpkoala mentioned this issue Apr 26, 2024
Closed
@fleet-release
Copy link
Contributor

Fleet starts anew,
MDM states no issue,
For secure review.

@georgekarrv georgekarrv removed the :demo label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roperzh roperzh

Labels
~backend Backend-related issue. bug Something isn't working as documented ~critical bug This is a critical bug and may require a patch release. #g-mdm MDM product group P0 Prioritize as emergency :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Milestone
4.49.1
Development

No branches or pull requests
5 participants
@georgekarrv @lukeheath @roperzh @xpkoala @fleet-release