Add new icons for Hosts page. Fix hosts list width on wide screens. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwass
approved these changes
Dec 15, 2020
Merged
noahtalerman
added a commit
that referenced
this pull request
Jan 7, 2021
- Conduct complete visual QA for recent icon changes merged in #128 - Edit styles to vertically align the "copy" and "reveal" icons in EnrollSecretTable - Clean up unused <KolideIcon /> properties in <SelectTargetsDropdown /> - Add min-height to left side navigation. At window heights under 500px, the user can now vertically scroll to reveal the remainder of the nav options. - Edit 500 page styles by moving the "Show error" button above the link to "File an issue"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Icon />component to<KolideIcon />and create a new<Icon />component. The ultimate goal is to get rid of the<KolideIcon />and<PlatformIcon />components and use the encompassing<Icon />component for all icons. The full transition will be made when we have icon assets to replace all the kolide icons and platform icons. Currently, we don't.icon_name_for_label.jsutility toicon_name.jsbecause the utility now includesiconNameForLabel()andiconNameForPlatform()functions.