Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when ABM terms have changed without requiring debug logging #14712

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

mna
Copy link
Member

@mna mna commented Oct 24, 2023

#13012

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.

@mna mna temporarily deployed to Docker Hub October 24, 2023 13:17 — with GitHub Actions Inactive
@mna mna marked this pull request as ready for review October 24, 2023 13:18
@mna mna requested a review from a team as a code owner October 24, 2023 13:18
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7067ca5) 58.87% compared to head (73e86d9) 58.86%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14712      +/-   ##
==========================================
- Coverage   58.87%   58.86%   -0.01%     
==========================================
  Files         924      924              
  Lines       77207    77207              
  Branches     2222     2222              
==========================================
- Hits        45452    45445       -7     
- Misses      28155    28160       +5     
- Partials     3600     3602       +2     
Flag Coverage Δ
backend 59.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/mdm/apple/apple_mdm.go 50.65% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna merged commit d0f276c into main Oct 24, 2023
16 checks passed
@mna mna deleted the mna-13012-clear-abm-terms-flag branch October 24, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants