-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet UI: Add iOS/iPadOS OS updates version requirements UI #20591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelElysia
commented
Jul 22, 2024
RachelElysia
force-pushed
the
fe-ipados-ios-version-requirements
branch
from
July 23, 2024 21:20
d76f939
to
2ac7341
Compare
RachelElysia
force-pushed
the
fe-ipados-ios-version-requirements
branch
from
July 24, 2024 17:42
5ade7fe
to
41e1e15
Compare
RachelElysia
commented
Jul 24, 2024
...ontrolsPage/OSUpdates/components/EndUserOSRequirementPreview/EndUserOSRequirementPreview.tsx
Outdated
Show resolved
Hide resolved
RachelElysia
commented
Jul 24, 2024
...ontrolsPage/OSUpdates/components/EndUserOSRequirementPreview/EndUserOSRequirementPreview.tsx
Outdated
Show resolved
Hide resolved
RachelElysia
force-pushed
the
fe-ipados-ios-version-requirements
branch
from
July 25, 2024 15:07
577e4b7
to
bd11a31
Compare
jacobshandling
previously requested changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the logic sound! I think there are a few worthwhile improvements we can make too.
frontend/pages/ManageControlsPage/OSUpdates/components/AppleOSTargetForm/AppleOSTargetForm.tsx
Show resolved
Hide resolved
...ontrolsPage/OSUpdates/components/EndUserOSRequirementPreview/EndUserOSRequirementPreview.tsx
Show resolved
Hide resolved
...ontrolsPage/OSUpdates/components/EndUserOSRequirementPreview/EndUserOSRequirementPreview.tsx
Outdated
Show resolved
Hide resolved
...ontrolsPage/OSUpdates/components/EndUserOSRequirementPreview/EndUserOSRequirementPreview.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/OSUpdates/components/TargetSection/TargetSection.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/OSUpdates/components/TargetSection/TargetSection.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/OSUpdates/components/TargetSection/TargetSection.tsx
Outdated
Show resolved
Hide resolved
RachelElysia
force-pushed
the
fe-ipados-ios-version-requirements
branch
from
July 26, 2024 17:13
8e26086
to
3fa0c91
Compare
RachelElysia
had a problem deploying
to
Docker Hub
July 26, 2024 17:13
— with
GitHub Actions
Failure
RachelElysia
had a problem deploying
to
Docker Hub
July 29, 2024 14:01
— with
GitHub Actions
Failure
RachelElysia
had a problem deploying
to
Docker Hub
July 29, 2024 14:41
— with
GitHub Actions
Failure
jacobshandling
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cerra #20470
Description
TODO
Screenrecording
https://www.loom.com/share/cce08488de8943ad938f69513280eef0?sid=9b42d9c6-9dcd-493f-9d9c-caaef5405ac7
Checklist for submitter
If some of the following don't apply, delete the relevant line.