address PR feedback for FileVault improvements #20935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedback left by @mna and @gillespi314 in #20842 related to #13157
roperzh
requested review from
a team,
lucasmrod,
getvictor and
gillespi314
as code owners
11 tasks
gillespi314
approved these changes
Aug 1, 2024
| if orbitClient.GetServerCapabilities().Has(fleet.CapabilityEscrowBuddy) { | ||
| orbitClient.RegisterConfigReceiver(update.NewEscrowBuddyRunner(updateRunner, 5*time.Minute)) | ||
| } else { | ||
| orbitClient.RegisterConfigReceiver(update.ApplyDiskEncryptionRunnerMiddleware()) |
There was a problem hiding this comment.
Someday we should rename ApplyDiskEncryptionRunnerMiddleware to make clear that it is macOS-only. Feel free to leave it as-is though.
There was a problem hiding this comment.
yeah, probably all of those, the majority still are named middlewares.
| @@ -870,11 +870,6 @@ func main() { | |||
| orbitClient.RegisterConfigReceiver(update.ApplyNudgeConfigReceiverMiddleware(update.NudgeConfigFetcherOptions{ | |||
| UpdateRunner: updateRunner, RootDir: c.String("root-dir"), Interval: nudgeLaunchInterval, | |||
| })) | |||
| if orbitClient.GetServerCapabilities().Has(fleet.CapabilityEscrowBuddy) { | |||
There was a problem hiding this comment.
Is this the fix for the issue Gabe found? Is it that we haven't initiated the capabilities checker yet?
There was a problem hiding this comment.
that's right, sorry for not being clear about it.
|
tests are failing until an endpoint ops feature is merged. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feedback left by @mna and @gillespi314 in #20842
also fixes a bug found by @PezHub #13157 (comment)
related to #13157
Checklist for submitter
If some of the following don't apply, delete the relevant line.