Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug when a cached prepared statement gets deleted in the MySQL server #21219

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

roperzh
Copy link
Contributor

@roperzh roperzh commented Aug 9, 2024

for #20781, I found this hard to reproduce, but apparently can happen in AWS Aurora when the server is upgraded under the hood.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

…L server

for #20781, I found this hard to reproduce, but apparently can happen in
AWS Aurora when the server is upgraded under the hood.
@roperzh
Copy link
Contributor Author

roperzh commented Aug 9, 2024

@getvictor I consider you the expert on prepared statements :). If you have time, could you take a look if this makes sense to you?

@roperzh roperzh marked this pull request as ready for review August 9, 2024 14:28
@roperzh roperzh requested a review from a team as a code owner August 9, 2024 14:28
getvictor
getvictor previously approved these changes Aug 9, 2024
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment.

server/datastore/mysql/mysql.go Outdated Show resolved Hide resolved
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roperzh roperzh merged commit a794bd2 into main Aug 9, 2024
12 checks passed
@roperzh roperzh deleted the 20781-cached-statements branch August 9, 2024 14:59
georgekarrv pushed a commit that referenced this pull request Aug 14, 2024
…L server (#21219)

for #20781, I found this hard to reproduce, but apparently can happen in
AWS Aurora when the server is upgraded under the hood.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants