Global Code Refactoring/Clean-up #3186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Please resolve merging conflict. |
# Conflicts: # packages/flet/lib/src/controls/safe_area.dart # packages/flet/lib/src/utils/colors.dart # packages/flet/lib/src/utils/text.dart
|
Conflict again. |
# Conflicts: # packages/flet/lib/src/controls/chip.dart # packages/flet/lib/src/controls/datatable.dart # packages/flet/lib/src/controls/segmented_button.dart # sdk/python/packages/flet-core/src/flet_core/icon_button.py
FeodorFitsner
approved these changes
May 24, 2024
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
* Enhance typing, use _set_enum_attr * Fix failing tests concerning TextOverflow.NONE * parseClip util * Filter children using isVisible * refactor parseCurve util * refactor parseTextAlign util * create parseTextOverflow util * create parseTextCapitalization util * create parseDismissDirection util * create parseOrientation util * refactor parseEdgeInsets util to accept defaultValue * refactor parseWrapAlignment util * refactor parseTabAlignment util * refactor parseWrapCrossAlignment util * refactor parseCrossAxisAlignment util * refactor parseMainAxisAlignment util * refactor parseAnimation util to accept defaultValue * refactor parseBorderRadius util to accept defaultValue * refactor parseRadius util to accept defaultValue * refactor parseTextInputType util to accept defaultValue * refactor parseBlur util to accept defaultValue * refactor parseImageRepeat util to accept defaultValue * refactor parseBoxFit util to accept defaultValue * create parseFilterQuality * refactor parseMouseCursor util: set null as default * refactor parseBrightness util * refactor parseRotate, parseScale, parseOffset utils to accept defaultValue * create parseStrokeCap and parseStrokeJoin * lowercase cursor values * create parseColor * refactor parseVisualDensity * refactor edge_insets.dart * refactor parseAlignment, alignmentFromJson * refactor parseIcon * refactor parseTileMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make code easier to use/reuse especially for new contributors.
(Part has been done in #3175 and #3263)