Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'enter-full-screen' and 'leave-full-screen' are not defined in WindowEventType #3857

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ndonkoHenri
Copy link
Collaborator

@ndonkoHenri ndonkoHenri commented Aug 23, 2024

Description

Fixes #3849

Summary by Sourcery

Fix missing definitions for 'enter-full-screen' and 'leave-full-screen' events in WindowEventType.

Bug Fixes:

  • Define 'enter-full-screen' and 'leave-full-screen' in WindowEventType to fix missing event types.

Copy link
Contributor

sourcery-ai bot commented Aug 23, 2024

Reviewer's Guide by Sourcery

This pull request adds two new event types to the WindowEventType enum and makes a minor formatting change to the SupportsStr protocol. The changes are straightforward and address the issue of missing full-screen event types.

File-Level Changes

Change Details Files
Add new full-screen event types to WindowEventType enum
  • Add LEAVE_FULL_SCREEN event type with value 'leave-full-screen'
  • Add ENTER_FULL_SCREEN event type with value 'enter-full-screen'
sdk/python/packages/flet-core/src/flet_core/types.py
Update SupportsStr protocol formatting
  • Change single-line ellipsis to multi-line ellipsis for str method
sdk/python/packages/flet-core/src/flet_core/types.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ndonkoHenri - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@FeodorFitsner FeodorFitsner merged commit 91f6408 into main Aug 27, 2024
3 checks passed
@FeodorFitsner FeodorFitsner deleted the fix-window-event-type branch August 27, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'enter-full-screen' 'leave-full-screen' is not a valid WindowEventType
2 participants