Fix the reconstructionGradientLimiter updater #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benflexcompute
added
current-version
hotfix
chai-flex
reviewed
Mar 8, 2024
| @@ -547,6 +547,12 @@ class TurbulenceModelSolverLegacy(TurbulenceModelSolver, LegacyModel): | |||
| rotation_correction: Optional[bool] = pd.Field(alias="rotationCorrection") | |||
|
|
|||
| def update_model(self): | |||
| if self.reconstruction_gradient_limiter is None: | |||
| if self.model_type == "SpalartAllmaras": | |||
There was a problem hiding this comment.
Is there a model object type we can compare against?
We should only define the mapping from model type string to object type in 1 place and then have the object type used everywhere
benflexcompute
commented
Mar 8, 2024
| "modelConstants": self.model_constants, | ||
| } | ||
|
|
||
| try_set(model, "rotationCorrection", self.rotation_correction) | ||
|
|
||
| if self.reconstruction_gradient_limiter is not None: | ||
| model["reconstructionGradientLimiter"] = self.reconstruction_gradient_limiter |
There was a problem hiding this comment.
It is still not ideal in the sense that not all default values are set by the SA/KOmega.
chai-flex
approved these changes
Mar 8, 2024
benflexcompute
added a commit
that referenced
this pull request
Mar 8, 2024
* Fix the reconstructionGradientLimiter updater * Comments addressed * Let the class handle defaults * Format * Lint
benflexcompute
added a commit
that referenced
this pull request
Mar 8, 2024
awkrupka
pushed a commit
that referenced
this pull request
Mar 10, 2024
* Fix the reconstructionGradientLimiter updater * Comments addressed * Let the class handle defaults * Format * Lint
maciej-flexcompute
added a commit
that referenced
this pull request
Mar 11, 2024
* bumped version to 24.2b1 * added copy example mesh (#192) * added copy mesh from example (#189) * bumped version and added copy example mesh * added update path * Fix crash when running _distribute_shared_output_fields with output_fields being None (#190) (#196) * Fix the reconstructionGradientLimiter updater (#195) (#197) * Fix the reconstructionGradientLimiter updater * Comments addressed * Let the class handle defaults * Format * Lint --------- Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.