-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade trimesh requirement to 4.* #1544
Comments
hey Lucas, could you assign someone? also maybe give it a priority and size in the Tidy3D tracking section so we can rank it among our other issues for importance, thanks. |
I can assign myself because of the transformations, but I won't be able to look into this for a while. If we want to increase the priority here, maybe someone else who's used trimesh could take a look. @weiliangjin2021, how's your plate now? |
Probably @caseyflex as he implemented this part? |
yeah I can take this. Do we want it as a patch for 2.6 or in 2.7? @tylerflex |
Thanks, 2.7 should be fine. |
Trimesh 4.* is not backwards compatible with 3.* (see #1538, for example), but gdsfactory requires trimesh >= 4 already.
It would be good to look into upgrading the requirement on our side.
The text was updated successfully, but these errors were encountered: