Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade trimesh requirement to 4.* #1544

Closed
lucas-flexcompute opened this issue Mar 14, 2024 · 5 comments · Fixed by #1557
Closed

Upgrade trimesh requirement to 4.* #1544

lucas-flexcompute opened this issue Mar 14, 2024 · 5 comments · Fixed by #1557
Assignees
Labels
2.7 will go into version 2.7.*

Comments

@lucas-flexcompute
Copy link
Collaborator

Trimesh 4.* is not backwards compatible with 3.* (see #1538, for example), but gdsfactory requires trimesh >= 4 already.
It would be good to look into upgrading the requirement on our side.

@tylerflex
Copy link
Collaborator

hey Lucas, could you assign someone? also maybe give it a priority and size in the Tidy3D tracking section so we can rank it among our other issues for importance, thanks.

@lucas-flexcompute
Copy link
Collaborator Author

I can assign myself because of the transformations, but I won't be able to look into this for a while. If we want to increase the priority here, maybe someone else who's used trimesh could take a look. @weiliangjin2021, how's your plate now?

@lucas-flexcompute lucas-flexcompute self-assigned this Mar 15, 2024
@weiliangjin2021
Copy link
Collaborator

Probably @caseyflex as he implemented this part?

@caseyflex caseyflex self-assigned this Mar 18, 2024
@caseyflex
Copy link
Contributor

yeah I can take this. Do we want it as a patch for 2.6 or in 2.7? @tylerflex

@tylerflex
Copy link
Collaborator

Thanks, 2.7 should be fine.

@caseyflex caseyflex linked a pull request Mar 18, 2024 that will close this issue
@caseyflex caseyflex added the 2.7 will go into version 2.7.* label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.*
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants