fix Environment object does not attribute _current if TIDY3D_ENV system variable is not empty #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
reviewed
Jul 24, 2023
There was a problem hiding this comment.
Thanks Juncheng,
- Could you add a line in CHANGELOG.md (under "fixed") something like "Web environment defaults to production if the TIDY3D_ENV system variable does not match an available environment key."
- We will merge this into pre/2.4 branch, after making changes, could you rebase against this branch and squash everything to a single commit?
JunchengXue
force-pushed
the
fix/environment
branch
2 times, most recently
from
1155fe0
to
b79730f
Compare
…em variable is not empty
JunchengXue
force-pushed
the
fix/environment
branch
from
b79730f
to
c84165c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.