Alec/intersections 2dbox #1040
Merged
Alec/intersections 2dbox #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you put in your comment fixes #1039 (note the #, also typing that sign on github will automatically give you a list of issues to search through), it should automatically link the issue and close it when the PR is merged. But it needs to be phrased exactly as "fixes #...". |
CHANGELOG.md
Outdated
| @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Fixed | |||
| - Adjoint plugin import failures after `jax.numpy.DeviceArray` -> `jax.Array` in jax 0.4.14. | |||
| - Changed definition of shapely box bounds in Geometry.intersections_2dbox() for issue 1039 | |||
There was a problem hiding this comment.
We usually don't reference issues in the changelog. Just Fixed definition of shapely box bounds in Geometry.intersections_2dbox(). works (note fixed as opposed to changed).
Could you update that and then squash the commits into 1? Then we can merge.
updated changelog
alec-flexcompute
force-pushed
the
alec/intersections_2dbox
branch
from
f696d25
to
a708369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue 1039