fix trianglemesh custom_dataset bug

[tylerflex]

The custom_datasets had the wrong logic. It was looping through geometry group items but not checking if they were TriangleMesh before grabbing the datasets. Was breaking Anderson localization (and probably metalens) notebooks.

For now, omitting changelog item since this bug was introduced in this commit and doesn't affect develop.

[caseyflex]

looks good, thanks for catching and fixing this. Is there a test we can add to make sure the custom_datasets are working correctly? I guess in this case it would error whenever it was called for a GeometryGroup containing geometries that weren't TriangleMesh.

[tylerflex]

Fair enough, I added a test but I'm seeing strange behavior. seems the custom_datasets is not what I'd expect. With two TriangleMesh geometries, I see 4 datasets, each of which is a tuple and two of which just contain ('type', 'TriangleMeshDataset'). Could you look into what's going on here? I'm kind of fuzzy on the workings of the triangle mesh.

[caseyflex]

Fair enough, I added a test but I'm seeing strange behavior. seems the custom_datasets is not what I'd expect. With two TriangleMesh geometries, I see 4 datasets, each of which is a tuple and two of which just contain ('type', 'TriangleMeshDataset'). Could you look into what's going on here? I'm kind of fuzzy on the workings of the triangle mesh.

I think changing the line in the custom_datasets to datasets_geometry += [geometry.mesh_dataset] fixes this

[tylerflex]

Yea that does seem to do it, although I guess it's also wrong in develop then?

[tylerflex]

oh wait, I think it's correct in develop actually since it's inside of a list comprehension.

[caseyflex]

Makes sense because the notebook tests would have caught it before release I suppose.

…

On Mon, Jul 31, 2023 at 7:16 PM Tyler Hughes ***@***.***> wrote: oh wait, I think it's correct in develop actually since it's inside of a list comprehension. — Reply to this email directly, view it on GitHub <#1041 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3KLECK7K5KBAUE6FG24MB3XS7ZBDANCNFSM6AAAAAA26SMK3A> . You are receiving this because your review was requested.Message ID: ***@***.***>