adjoint filter cleanup and additions #1093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircularFilter
, which is just a uniform "cylinder" kernel instead of a conic kernel.feature_size
toradius
in the circular filters.sqrt(3)
in the radius calculation, which is inconsistent with literature.Note: initial testing of the circular filter is showing that it's terrible compared to conic filter, so not mentioning it in the changelog for now.