Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message when user try to download data that doesn't exist. #1246

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

magiWei
Copy link

@magiWei magiWei commented Nov 11, 2023

No description provided.

Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magiWei. Please also include a changing item under "fixed"

Improved error handling if file can not be downloaded from server.

Our practice is to include a changelog item for any non-trivial change to our code so we have a clear record of the timeline for various change. thank you!

tidy3d/web/api/mode.py Outdated Show resolved Hide resolved
tidy3d/web/core/task_core.py Show resolved Hide resolved
@magiWei magiWei force-pushed the qingeng/SCEM-4147 branch 2 times, most recently from 772f07a to 59275eb Compare November 14, 2023 02:20
@magiWei
Copy link
Author

magiWei commented Nov 14, 2023

Thanks @magiWei. Please also include a changing item under "fixed"

Improved error handling if file can not be downloaded from server.

Our practice is to include a changelog item for any non-trivial change to our code so we have a clear record of the timeline for various change. thank you!

added.

@momchil-flex momchil-flex merged commit 77f8076 into pre/2.5 Nov 14, 2023
12 checks passed
@momchil-flex momchil-flex deleted the qingeng/SCEM-4147 branch November 14, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants