Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some private helper properties in ModeSolver #1255

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Some private helper properties in ModeSolver #1255

merged 2 commits into from
Dec 4, 2023

Conversation

momchil-flex
Copy link
Collaborator

No description provided.

@momchil-flex momchil-flex force-pushed the momchil/charge_mode branch 3 times, most recently from 8a9dc75 to 34298be Compare November 24, 2023 22:54
@momchil-flex
Copy link
Collaborator Author

@dbochkov-flexcompute could you take another look? I introduced a new commit to avoid erroring out if ModeSolver is imported but scipy is not installed. This is so that we can e.g. run metadata on ModeSolver objects using our web services while keeping those small.

@dbochkov-flexcompute
Copy link
Contributor

@dbochkov-flexcompute could you take another look? I introduced a new commit to avoid erroring out if ModeSolver is imported but scipy is not installed. This is so that we can e.g. run metadata on ModeSolver objects using our web services while keeping those small.

yeah, all makes sense to me

@momchil-flex momchil-flex merged commit fe7e4e7 into pre/2.5 Dec 4, 2023
14 checks passed
@momchil-flex momchil-flex deleted the momchil/charge_mode branch December 4, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbochkov-flexcompute dbochkov-flexcompute dbochkov-flexcompute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momchil-flex @dbochkov-flexcompute