Handle all remaining lint errors in tests #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaugenst-flex
force-pushed
the
yaugenst-flex/fix_test_lint
branch
from
dbf11c1
to
66aaf06
Compare
|
Looks like some fixture isnt' working in |
yaugenst-flex
force-pushed
the
yaugenst-flex/fix_test_lint
branch
from
2216d21
to
e36f6c6
Compare
tylerflex
approved these changes
May 7, 2024
There was a problem hiding this comment.
Looks good. For anyone viewing this later, this PR basically just fixes any existing warnings that came up when ruff check was applied to the tests. It seemed before we really only started with a tidy3d/ directory passing with ruff and the tests and pre-commit only tested files that were changed in the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were still throwing a lot of lint errors, which made writing new ones a bit of a pain due to our pre-commit config.
Before (181 errors total):
After: