Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra check to avoid a shapely warning when .intersects an empty shape #740

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Extra check to avoid a shapely warning when .intersects an empty shape #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tidy3d/components/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1837,7 +1837,7 @@ def _filter_structures_plane( # pylint:disable=too-many-locals
continue

# look more closely to see if intersected.
if not shape.intersects(_shape):
if _shape.is_empty or not shape.intersects(_shape):
continue

diff_shape = _shape - shape
Expand Down