Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for hip gpu backends #392

Merged
merged 15 commits into from
Nov 8, 2022

Commits on Nov 7, 2022

  1. Update cmake to handle gpu backend

    Previously, cmake would always build targeting cuda.
    
    We now dispatch on FF_GPU_BACKEND to target either cuda, hip_cuda,
    or hip_rocm. The hip backends are expected to use the hip cmake config
    file that comes with a hip install. The discrepancies for targeting
    hip_cuda vs hip_rocm are documented inline.
    
    Configure legion for hip backend
    williamberman committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    04382c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c351126 View commit details
    Browse the repository at this point in the history
  3. docker build updates

    williamberman committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    5183791 View commit details
    Browse the repository at this point in the history
  4. Small source modifications for build

    add legion max return size check
    
    fix std::stringstream var decl parsed as function
    
    explicit template instantiations
    include string
    williamberman committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    4c92738 View commit details
    Browse the repository at this point in the history
  5. Move tools to top level directory

    We glob for files under src to get the source files for the flexflow
    target. Moving tools to the top level directory prevents the tools
    sourcefiles from accidentally being added to the flexflow target
    source files.
    
    change substitution_to_dot cuda_add_executable to add_executable.
    When building with hip_rocm, we don't have cuda available and shouldn't
    need to build with it for substitution_to_dot as the target does
    not directly build and cuda kernels
    williamberman committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f8fd33a View commit details
    Browse the repository at this point in the history
  6. fix miopen.h headers

    williamberman committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    076d1f9 View commit details
    Browse the repository at this point in the history
  7. Fix hip kernels

    williamberman committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    5333d8a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    beeb8eb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    453b6f2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9a1d868 View commit details
    Browse the repository at this point in the history
  11. Add new lines

    williamberman committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    bf96efc View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Fix CI for changes in PR

    do not call sed to manually change config script
    
    clone submodules in docker job
    williamberman committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    049c3a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8c4ed4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fdf422d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a366c98 View commit details
    Browse the repository at this point in the history