-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for hip gpu backends #392
Merged
Merged
Commits on Nov 7, 2022
-
Update cmake to handle gpu backend
Previously, cmake would always build targeting cuda. We now dispatch on FF_GPU_BACKEND to target either cuda, hip_cuda, or hip_rocm. The hip backends are expected to use the hip cmake config file that comes with a hip install. The discrepancies for targeting hip_cuda vs hip_rocm are documented inline. Configure legion for hip backend
Configuration menu - View commit details
-
Copy full SHA for 04382c0 - Browse repository at this point
Copy the full SHA 04382c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c351126 - Browse repository at this point
Copy the full SHA c351126View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5183791 - Browse repository at this point
Copy the full SHA 5183791View commit details -
Small source modifications for build
add legion max return size check fix std::stringstream var decl parsed as function explicit template instantiations include string
Configuration menu - View commit details
-
Copy full SHA for 4c92738 - Browse repository at this point
Copy the full SHA 4c92738View commit details -
Move tools to top level directory
We glob for files under src to get the source files for the flexflow target. Moving tools to the top level directory prevents the tools sourcefiles from accidentally being added to the flexflow target source files. change substitution_to_dot cuda_add_executable to add_executable. When building with hip_rocm, we don't have cuda available and shouldn't need to build with it for substitution_to_dot as the target does not directly build and cuda kernels
Configuration menu - View commit details
-
Copy full SHA for f8fd33a - Browse repository at this point
Copy the full SHA f8fd33aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 076d1f9 - Browse repository at this point
Copy the full SHA 076d1f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5333d8a - Browse repository at this point
Copy the full SHA 5333d8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for beeb8eb - Browse repository at this point
Copy the full SHA beeb8ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 453b6f2 - Browse repository at this point
Copy the full SHA 453b6f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a1d868 - Browse repository at this point
Copy the full SHA 9a1d868View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf96efc - Browse repository at this point
Copy the full SHA bf96efcView commit details
Commits on Nov 8, 2022
-
do not call sed to manually change config script clone submodules in docker job
Configuration menu - View commit details
-
Copy full SHA for 049c3a1 - Browse repository at this point
Copy the full SHA 049c3a1View commit details -
Change the python setup script to shell out to the config script inst…
…ead of parsing it adhoc
Configuration menu - View commit details
-
Copy full SHA for a8c4ed4 - Browse repository at this point
Copy the full SHA a8c4ed4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdf422d - Browse repository at this point
Copy the full SHA fdf422dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a366c98 - Browse repository at this point
Copy the full SHA a366c98View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.