Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace light-mode screenshot with dark-mode #4

Closed
wants to merge 1 commit into from
Closed

Replace light-mode screenshot with dark-mode #4

wants to merge 1 commit into from

Conversation

adiabatic
Copy link

Closes #3.

I tried making the screenshot pair responsive with picture/source. Unfortunately, GitHub rewrites image URLs for standard Markdown links (![…](…)) but not URLs in HTML.

@flexibeast
Copy link
Owner

Thanks for doing this! However, with regards to the PR's title, i'm not willing to simply replace a 'light'-mode screencap with a 'dark' one, given that i'm one of a number of people who find 'dark' themes difficult to read. My preference is to find some way of including both regardless of GitHub's limitations. So to that end, i've changed the guide to now read:

The resulting formatted output is visible in the following screencaps:

for dark-themed environments
for light-themed environments

using the screencap you provided. Does that work for you?

@adiabatic
Copy link
Author

Sounds good to me. Here are a pair of light and dark screenshots if you're into matching pairs:

mdoc-examples-7-light

mdoc-examples-7-dark

@flexibeast
Copy link
Owner

Sounds good to me.

Great, i'll close this PR then.

Here are a pair of light and dark screenshots if you're into matching pairs:

At this stage i won't use the screencap pair you provided, but might end up doing so at some point in the future. :-)

@flexibeast flexibeast closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdoc-quickstart: Request: add dark-mode screenshot for dark-mode users
2 participants