Handle "null" json responses

[iaddict]

"null" gets parsed to nil and causes the following code to break.

With this patch nil gets returned.

[andyjeffries]

I think I'd rather it returned an empty object of the current class rather than nil, that way you can still check things like the return status or have callbacks extract standard custom headers, etc.

[coveralls]

Coverage increased (+0.06%) to 98.73% when pulling d439d73 on iaddict:patch-2 into 696d08e on flexirest:master.

[iaddict]

Ok. This would be fine too.
Actually this also was my first thought :).

[andyjeffries]

Would you like to resubmit a PR with that response, or close this one and open a new one, or close this one and I'll do it when I get a chance ;-) ?

[andyjeffries]

Wow, that was quick!

[iaddict]

Many thanks for this gem 👍. Hope that this PR is ok.

[andyjeffries]

Actually, is there a test for this? The existing @response.body.blank? should catch #nil? but you said it was when it returned the string null. Or maybe the code should be:

begin
  if @response.body.blank? || @response.body == "null"
    body = {}
  else 
    body = MultiJson.load(@response.body)
  end
rescue MultiJson::ParseError
  raise ResponseParseException.new(status:@response.status, body:@response.body, headers:@response.headers)
end

[andyjeffries]

And you're very welcome for the gem, glad you like it :-)

[iaddict]

This also would be an option. I thought it would be more safe to let the json parser decide what a null value actually is. But the string comparison may also be an option. I'll change it.

[andyjeffries]

Ahhhh OK, ignore me - I thought the JSON parser was failing on the null. Don't worry, your last commit is fine then.

[iaddict]

Great! Many thanks!

[andyjeffries]

Released as v1.7.2

[iaddict]

Perfect. That was also fast :).