fix(Windows:Link): Initial fix that passes the link phase #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrieleKaceviciute
requested changes
Jun 21, 2024
There was a problem hiding this comment.
I've tested on Windows 10 Pro, Node v18.19.0 ->
C:\Users\dev\Desktop\hello-renative>rnv link
┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │
│ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │
│ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │
│ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │
│ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │
│ RNV v:1.0.0-rc.19 | renative.org | 21/06/2024, 11:21:47 │
│ $ rnv link │
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-core (C:\Users\dev\Desktop\renative\packages\engine-core\lib)
task: ○ link ↺1
info: Found following source packages:
C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\adapter (unlinked)
C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\cli (unlinked)
C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\config-templates (unlinked)
C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\core (unlinked)
C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\engine-core (unlinked)
C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\sdk-telemetry (unlinked)
C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\sdk-utils (unlinked)
C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\template-starter (unlinked)
? Found following packages to link? @rnv/adapter, @rnv/cli, @rnv/config-templates, @rnv/core, @rnv/engine-core, @rnv/sdk
-telemetry, @rnv/sdk-utils, @rnv/template-starter
info: Linking packages...
error: ⨯ Error: EPERM: operation not permitted, symlink 'C:\Users\dev\Desktop\renative\packages\adapter' -> 'C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\adapter'
at Object.symlinkSync (node:fs:1814:3)
at fsSymlinkSync (C:\Users\dev\Desktop\renative\packages\core\src\system\fs.ts:59:8)
at _linkPackage (C:\Users\dev\Desktop\renative\packages\engine-core\src\tasks\linking\taskLink.ts:36:22)
at C:\Users\dev\Desktop\renative\packages\engine-core\src\tasks\linking\taskLink.ts:84:13
at Array.forEach (<anonymous>)
at C:\Users\dev\Desktop\renative\packages\engine-core\src\tasks\linking\taskLink.ts:83:34
at step (C:\Users\dev\Desktop\renative\node_modules\tslib\tslib.js:195:27)
at Object.next (C:\Users\dev\Desktop\renative\node_modules\tslib\tslib.js:176:57)
at fulfilled (C:\Users\dev\Desktop\renative\node_modules\tslib\tslib.js:166:62)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
┌─────────────────────────────────────────────────────────────────┐
│ ⨯ SUMMARY | 21/06/2024, 11:21:49 | rnv@1.0.0-rc.19 │
│ $ rnv link │
├─────────────────────────────────────────────────────────────────┤
│ Project: hello-renative@0.1.0 │
│ Workspace: rnv │
│ Engine: @rnv/engine-core │
│ Build Scheme (-s): debug │
│ Env Info: win32 | x64 | node v18.19.0 │
│ Executed Time: 0h:0m:1s:538ms │
│ error: ⨯ Error: EPERM: operation not permitted, symlink 'C:\Users\dev\Desktop\renative\packages\adapter' -> 'C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\adapter'
at Object.symlinkSync (node:fs:1814:3)
at fsSymlinkSync (C:\Users\dev\Desktop\renative\packages\core\src\system\fs.ts:59:8)
at _linkPackage (C:\Users\dev\Desktop\renative\packages\engine-core\src\tasks\linking\taskLink.ts:36:22)
at C:\Users\dev\Desktop\renative\packages\engine-core\src\tasks\linking\taskLink.ts:84:13
at Array.forEach (<anonymous>)
at C:\Users\dev\Desktop\renative\packages\engine-core\src\tasks\linking\taskLink.ts:83:34
at step (C:\Users\dev\Desktop\renative\node_modules\tslib\tslib.js:195:27)
at Object.next (C:\Users\dev\Desktop\renative\node_modules\tslib\tslib.js:176:57)
at fulfilled (C:\Users\dev\Desktop\renative\node_modules\tslib\tslib.js:166:62)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
└─────────────────────────────────────────────────────────────────┘
(node:424) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)
C:\Users\dev\Desktop\hello-renative>
Cleaned everything and cannot reproduce the error, am I doing anything wrong? I am testing on Windows 10 22H PC. |
|
@RicardasN steps seems the same -> |
|
On my personal win pc works, minion same result as @GabrieleKaceviciute |
GabrieleKaceviciute
approved these changes
Jun 27, 2024
Marius456
requested changes
Jun 28, 2024
Marius456
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Npm releases
n/a
Screenshots