Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up debug & logger a little. #193

Merged
merged 1 commit into from
Oct 30, 2013
Merged

Cleaned up debug & logger a little. #193

merged 1 commit into from
Oct 30, 2013

Conversation

tgvashworth
Copy link
Contributor

Nothing major, just unified the style a little bit.

@necolas
Copy link
Contributor

necolas commented Oct 24, 2013

lgtm

@angus-c
Copy link
Contributor

angus-c commented Oct 24, 2013

could we go a step further and put if (window.DEBUG && window.DEBUG.enabled) around the body of withLogging?

@tgvashworth
Copy link
Contributor Author

That would mean you can't enable logging later, right? Unless you register (and deregister?) the advice when enabled changes.

@angus-c
Copy link
Contributor

angus-c commented Oct 30, 2013

true

angus-c added a commit that referenced this pull request Oct 30, 2013
Cleaned up debug & logger a little.
@angus-c angus-c merged commit dec27d2 into flightjs:master Oct 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants