Fixing IFramed application exceptions caused by window.localStorage in Flight #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
want to land this, but trying to get travis to npm install without griping (not your fault) |
|
Awesome! Thanks for the update @angus-c ! |
|
Would you mind merging from master? (there was a karma peer dependency issue that was making travis fail) |
|
Do you mean merge with master? I do not know what that would do though, there does not seem to be any differences other than those I made. |
…wise window.localStorage calls can crash iframed applications using flight
|
Rebased with your new master. Can you rerun TravisCI? |
|
thanks (I tweaked package.json). All good now |
angus-c
added a commit
that referenced
this pull request
Mar 28, 2014
…e_when_using_twitter_flight_through_an_iframe Fixing IFramed application exceptions caused by window.localStorage in Flight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment:
OSX Build 13C64
Chrome Version 33.0.1750.152
Flight version 1.0.9 (Can also replicate on 1.1.3)
Steps to reproduce:
This is quite a severe bug for us and I would appreciate feedback ASAP. Thanks.