Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build process #272

Merged
merged 4 commits into from
Jun 26, 2014
Merged

Simplify build process #272

merged 4 commits into from
Jun 26, 2014

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Jun 25, 2014

Use webpack to build the exported library.

  • The build is now a UMD bundle so it will work as a global, with AMD, or CommonJS.
  • No real changes required to get this working with CommonJS modules (see the POC branch).

Karma housekeeping

  • Install karma-cli for convenience of npm-scripts.
  • Remove phantomJS launcher.

@angus-c
Copy link
Contributor

angus-c commented Jun 26, 2014

this is excellent - really like webpack

@@ -0,0 +1,17 @@
var BannerPlugin = require('webpack/lib/BannerPlugin');
var version = require('./package.json').version;
var webpack = require('webpack');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove this before merge.

@necolas
Copy link
Contributor Author

necolas commented Jun 26, 2014

Fixed the unused 'require'. Should be good to merge now.

angus-c added a commit that referenced this pull request Jun 26, 2014
@angus-c angus-c merged commit 7425046 into master Jun 26, 2014
@necolas necolas deleted the simplify-build-process branch August 7, 2014 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants