Add style checker to npm test
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,35 @@ | |||
| { | |||
There was a problem hiding this comment.
should use 2 space indentation
angus-c
added a commit
that referenced
this pull request
Jul 30, 2014
Add style checker to `npm test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding JSCS with an initially liberal style check to npm test. This will run after the karma tests (including in Travis). The rules can be tightened later if agreed.
Fixed existing code conform to our initial JSCS rules.
I also added a pre-commit hook but for some reason symlinking it to
.git/hooksdid not work - so you may have to copy it there manually