Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Advice API doc for event and data params, multiple advice #330

Merged
merged 1 commit into from
Jan 16, 2015
Merged

Update Advice API doc for event and data params, multiple advice #330

merged 1 commit into from
Jan 16, 2015

Conversation

prashaantt
Copy link
Contributor

Adds documentation to go with #299.

@prashaantt
Copy link
Contributor Author

Uh, I looked around and saw you're trying to deprecate jQuery dependence in a future release (#320). I think most of these changes will still pass, except for my specific mention of jQuery events at one place. I suppose the event object is going to stay but no longer as a jQuery object?

@tgvashworth
Copy link
Contributor

Thanks for this!

Yeah, the event object will stay — but the jQuery change is quite a while away and I think there will be a big documentation rework at the same time.

tgvashworth added a commit that referenced this pull request Jan 16, 2015
@tgvashworth
Merge pull request #330 from prashaantt/advice_doc_update
90ab5c4 
Update Advice API doc for event and data params, multiple advice
@tgvashworth tgvashworth merged commit 90ab5c4 into flightjs:master Jan 16, 2015
@tgvashworth
Copy link
Contributor

Thanks!

@prashaantt
Copy link
Contributor Author

I missed updating the Readme. Looks like I'll need to creater another PR. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashaantt @tgvashworth