Dispatcher should check for valid callback.

flightphp · Dec 19, 2013 · 6696c0d · 6696c0d
1 parent 3fde368
commit 6696c0d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/flight/core/Dispatcher.php b/flight/core/Dispatcher.php
@@ -141,7 +141,9 @@ public static function execute($callback, array &$params = array()) {
                 self::invokeMethod($callback, $params) :
                 self::callFunction($callback, $params);
         }
-        return null;
+        else {
+            throw new \Exception('Invalid callback specified.');
+        }
     }
 
     /**

diff --git a/tests/DispatcherTest.php b/tests/DispatcherTest.php
@@ -82,4 +82,11 @@ function testBeforeAndAfter() {
 
         $this->assertEquals('Hello, Fred! Have a nice day!', $result);
     }
+
+    // Test an invalid callback
+    function testInvalidCallback() {
+        $this->setExpectedException('Exception', 'Invalid callback specified.');
+
+        $this->dispatcher->execute(array('NonExistentClass', 'nonExistentMethod'));
+    }
 }