adding in AppFactory chain mixins #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehokm
approved these changes
Apr 19, 2018
KokeClassic
approved these changes
Apr 19, 2018
benschw
reviewed
Apr 19, 2018
|
|
||
| public function addAppFactory(AppFactory $appFactory) { |
There was a problem hiding this comment.
Should this be wrapDefaultInvokerApp to support the possibility of injecting apps in other areas of the chain at a later date? addAppFactory sounds too generic for how specific the implementation is
There was a problem hiding this comment.
Considering this is the opinionated implementation of fliglio, the default apps are necessary for the framework to work/bootstrap. The only possible injection point is right before the DefaultInvoker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.