Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating PR #755 following Isuru's comments #756

Merged
merged 1 commit into from
May 31, 2020
Merged

updating PR #755 following Isuru's comments #756

merged 1 commit into from
May 31, 2020

Conversation

dimpase
Copy link
Contributor

@dimpase dimpase commented May 31, 2020

Thanks to @isuruf for pointing that these are not needed.

@dimpase dimpase mentioned this pull request May 31, 2020
Merged
@wbhart
Copy link
Collaborator

wbhart commented May 31, 2020

I'm also curious why the default of -ansi for CFLAGS doesn't work on FreeBSD or OpenBSD. It seems strange to have to set it to c99 when Flint is not a c99 library.

@dimpase
Copy link
Contributor Author

dimpase commented May 31, 2020

#755 only included -I, it didn't touch other C flags for FreeBSD.
(and the addition of -I is being removed here)

@dimpase dimpase mentioned this pull request May 31, 2020
Closed
@dimpase
Copy link
Contributor Author

dimpase commented May 31, 2020

#333 explains the need to remove pedantic, due to inline in C code.

@wbhart wbhart merged commit f6701cd into flintlib:trunk May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimpase @wbhart