-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename l_function method name #212
Conversation
fixes E743
src/flint/types/dirichlet.pyx
Outdated
# For backwards compatibility we allow self.l(s) see Issue #210 | ||
l = l_function # no-cython-lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't any point in doing this unless the docstring is updated to suggest calling the new function name.
I would do it like:
def l_function(self, s):
"""
>>> l_function()
123
"""
...
def l(self, s):
"""
Alias for :meth:`l_function`
"""
return self.l_function(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry, i just missed this
I'm not sure it is worth changing the name here. I don't know much about this function and I don't know what it would normally be called. If the linter wasn't complaining then it would not have been suggested to change this so I would probably just leave it I think. Putting "function" in the name seems sort of redundant when most methods are functions. |
reviewer feedback
7a1a24a
to
5af4b65
Compare
I think |
Okay, let's get it in. |
Fixes #210