Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addFiles property seems missleading #4

Closed
BonneVoyager opened this issue Nov 10, 2016 · 3 comments
Closed

addFiles property seems missleading #4

BonneVoyager opened this issue Nov 10, 2016 · 3 comments
Labels
enhancement

Comments

@BonneVoyager
Copy link
Contributor

addFiles property was misleading for me at first. With something like addThemeFiles or addStyleFiles it would be quite obvious what the property does.
@flipace
Copy link
Owner

flipace commented Nov 10, 2016

Good point.

I think "addStyleFiles" may be a better choice here.

Want to give it a spin with a PR?

@BonneVoyager
Copy link
Contributor Author

Yes, thank you. I will push a PR sometime soon.

BonneVoyager added a commit to BonneVoyager/react-themeit that referenced this issue Nov 11, 2016
@BonneVoyager
replaced addFiles property with addStyleFiles flipace#4
382e8d6
flipace pushed a commit that referenced this issue Nov 11, 2016
@BonneVoyager @flipace
addFiles property seems missleading #4 (#5)
b5b6963 
* replaced addFiles property with addStyleFiles #4

* 1.1.0

* removed console.log
@flipace
Copy link
Owner

flipace commented Nov 11, 2016

thanks!

@flipace flipace closed this as completed Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flipace @BonneVoyager