Pulsar producer implementation. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravAshok
reviewed
Oct 20, 2023
| @@ -148,6 +148,10 @@ tasks.withType(JacocoReport).configureEach { | |||
| getExecutionData().from(fileTree(buildDir).include("/jacoco/*.exec")) | |||
| } | |||
|
|
|||
| tasks.withType(Copy).configureEach { | |||
There was a problem hiding this comment.
why is this required?
There was a problem hiding this comment.
gradle/gradle#17236
Moved it to ProcessResource task and WARN strategy for Pulsar module alone.
common/src/main/java/com/flipkart/varadhi/exceptions/MessagingException.java
Show resolved
Hide resolved
entities/src/main/java/com/flipkart/varadhi/entities/CapacityPolicy.java
Show resolved
Hide resolved
entities/src/main/java/com/flipkart/varadhi/entities/Message.java
Outdated
Show resolved
Hide resolved
pulsar/src/main/java/com/flipkart/varadhi/pulsar/entities/PulsarProducer.java
Outdated
Show resolved
Hide resolved
pulsar/src/main/java/com/flipkart/varadhi/pulsar/entities/PulsarProducer.java
Outdated
Show resolved
Hide resolved
pulsar/src/main/java/com/flipkart/varadhi/pulsar/entities/PulsarProducer.java
Show resolved
Hide resolved
Comment on lines
9
to
26
| return 0; | ||
| if (null == o) { | ||
| throw new ArgumentException("Can not compare null ProducerResult."); | ||
| } | ||
| if (o instanceof PulsarProducerResult) { | ||
| return messageId.compareTo(((PulsarProducerResult) o).messageId); | ||
| } else { | ||
| throw new ArgumentException(String.format( | ||
| "Can not compare different ProducerResult types. Expected ProducerResult is %s, given %s.", | ||
| PulsarProducerResult.class.getName(), o.getClass().getName() | ||
| )); | ||
| } |
There was a problem hiding this comment.
auto-generated?
Also, there is no requirement for ProduceResult to be comparable. Is there?
There was a problem hiding this comment.
U mean ProduceResult or ProducerResult ?
For former comparable is not required as it is more then message offset. Renamed this class to be Offset and PulsarOffset, however retained the Comparable for Offset.
server/src/main/java/com/flipkart/varadhi/web/v1/produce/ProduceHandlers.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:: will add tests after first review.