TestHelp: Fix setup for RSpec, clear adapter before each test #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me! |
|
Not using RSpec, just minitest |
Sorry about that. I just CC'd everyone from #808 |
rnestler
approved these changes
Jan 18, 2024
|
Sorry, still fails for me with the exact same output as in #822. Again, if you think your code is working as it should, I have no problem adjusting our usage. If the Flipper state is being wiped after each example we probably don't need the |
|
Works for me (using rspec) - thanks for a quick fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #821 and fix #822.
I can't get a failing RSpec spec in this repo right now, but will work on refactoring our test suite to get one similar to
test_rails/system/test_help_test.rbfor rspec.@danielmorrison @norman @rnestler @davidwessman @fcheung can you test this branch and confirm that it works for you?
cc #808