Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3132] HID app: Add new function key icons #3236

Merged
merged 4 commits into from
Dec 2, 2023
Merged

[FL-3132] HID app: Add new function key icons #3236

merged 4 commits into from
Dec 2, 2023

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Nov 21, 2023 •
edited by skotopes
Loading

What's new

  • HID apps now have a new row of function keys with prettier text

Verification

  • Check that the keys have changed and work as expected

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

Compiled f7 firmware for commit 393f7bed:

skotopes
skotopes previously approved these changes Nov 30, 2023
View reviewed changes
@skotopes skotopes marked this pull request as draft November 30, 2023 09:57
@Astrrra Astrrra marked this pull request as ready for review November 30, 2023 22:09
@skotopes skotopes merged commit 9373286 into dev Dec 2, 2023
9 checks passed
@skotopes skotopes deleted the astra/3132-hid-icons branch December 2, 2023 04:52
hryamzik added a commit to hryamzik/flipperzero-firmware that referenced this pull request Dec 4, 2023
@hryamzik
hid_app: cleaned icons that where conflicting flipperdevices#3236
fb5f50c
@hryamzik hryamzik mentioned this pull request Dec 4, 2023
Closed
3 tasks
tpimh pushed a commit to tpimh/flipper-jackbox-remote that referenced this pull request Mar 5, 2024
@Astrrra @skotopes
[FL-3132] HID app: Add new function key icons (flipperdevices#3236)
9361807 
* Add new function key icons
* Fix graphical glitches on the buttons

Co-authored-by: あく <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Astrrra @skotopes