Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jsonschema to correctly validate key|keys in rollout segment #2947

Merged

Conversation

halcyonCorsair
Copy link
Contributor

Correctly validate both cases for rollout segment in the JSON schema:

    rollouts:
      - segment:
          key: Single-Constraint
          value: false
      - segment:
          keys:
            - Single-Constraint
            - Any-Constraint-Segment
          value: false

@halcyonCorsair halcyonCorsair requested a review from a team as a code owner April 4, 2024 01:47
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.25%. Comparing base (f997fb9) to head (1b95c16).
Report is 207 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2947      +/-   ##
==========================================
+ Coverage   70.78%   72.25%   +1.46%     
==========================================
  Files          91       91              
  Lines        8729     7064    -1665     
==========================================
- Hits         6179     5104    -1075     
+ Misses       2165     1579     -586     
+ Partials      385      381       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🙏

@GeorgeMac GeorgeMac merged commit 70302a1 into flipt-io:main Apr 4, 2024
27 checks passed
@markphelps
Copy link
Collaborator

@all-contributors please add @halcyonCorsair for code

Copy link
Contributor

@markphelps

I've put up a pull request to add @halcyonCorsair! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants