Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): change the order of queries for mysql #3039

Merged
merged 1 commit into from
May 2, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented May 1, 2024

resolves #3037

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.24%. Comparing base (f997fb9) to head (8cbd820).
Report is 288 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
+ Coverage   70.78%   72.24%   +1.45%     
==========================================
  Files          91       98       +7     
  Lines        8729     7425    -1304     
==========================================
- Hits         6179     5364     -815     
+ Misses       2165     1661     -504     
- Partials      385      400      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka erka marked this pull request as ready for review May 1, 2024 19:54
@erka erka requested a review from a team as a code owner May 1, 2024 19:54
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @erka ! trying to think through it, but i guess its ok for existing users that have already run this migration as it wont re-run. and if they are running into issues from the mysql8 change then they could / would have to run against a new db

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, yeah should be ok to rewrite history in this way.

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label May 2, 2024
@kodiakhq kodiakhq bot merged commit 4b3520e into flipt-io:main May 2, 2024
28 checks passed
@erka erka deleted the mysql-migrations branch May 2, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-978] Issue with latest mysql 8 release
3 participants