-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): allow authorization for Github and OIDC behind the reverse proxy #3135
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3135 +/- ##
==========================================
+ Coverage 70.78% 71.08% +0.29%
==========================================
Files 91 109 +18
Lines 8729 7981 -748
==========================================
- Hits 6179 5673 -506
+ Misses 2165 1869 -296
- Partials 385 439 +54 ☔ View full report in Codecov by Sentry. |
@erka is this ready for review? |
@markphelps It works, but it's not ideal. The |
proxy Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com> Co-authored-by: George MacRorie <me@georgemac.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you @erka !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Nice one @erka . Thanks for making this happen, it was a fiddly one.
And @tvcsantos for initial contrib and ideas around x-forwarded-prefix.
Thanks for the efforts guys. Really cool 👍 |
No description provided.