Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to copy evaluate command in a CLI format #3154

Conversation

kyryl-perepelytsia
Copy link
Contributor

@kyryl-perepelytsia kyryl-perepelytsia commented Jun 7, 2024

Related to #2863

@kyryl-perepelytsia kyryl-perepelytsia requested a review from a team as a code owner June 7, 2024 15:29
@GeorgeMac
Copy link
Contributor

Hey @kyryl-perepelytsia 👋 Thanks for the PR. Are you planning to push more up into this PR?
Seems like just a type definition so far.

Signed-off-by: kyryl.perepelytsia <sooperkiras@gmail.com>
@kyryl-perepelytsia
Copy link
Contributor Author

hey @GeorgeMac, sorry my bad, i have re-pushed all changes

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great on my end. 👏 Thank you @kyryl-perepelytsia

@markphelps
Copy link
Collaborator

@all-contributors please add @kyryl-perepelytsia for code

Copy link
Contributor

@markphelps

I've put up a pull request to add @kyryl-perepelytsia! 🎉

@markphelps
Copy link
Collaborator

Works great @kyryl-perepelytsia ! Thank you for the PR! one minor bit of feedback, I think the spacing between the buttons is a bit off in the UI

In 'desktop' view I feel like the spacing is too large between the button and the dropdown

Xnapper-2024-06-10-09 38 26

In mobile view there is some overlap.

Screen Shot 2024-06-10 at 09 36 35

wdyt?

Signed-off-by: kyryl.perepelytsia <sooperkiras@gmail.com>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (f997fb9) to head (5e5984e).
Report is 399 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
+ Coverage   70.78%   71.59%   +0.80%     
==========================================
  Files          91      109      +18     
  Lines        8729     7987     -742     
==========================================
- Hits         6179     5718     -461     
+ Misses       2165     1842     -323     
- Partials      385      427      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you @kyryl-perepelytsia . I'll see if I can adjust the button gaps in a follow up

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jun 12, 2024
@markphelps markphelps merged commit a143262 into flipt-io:main Jun 12, 2024
31 checks passed
@kyryl-perepelytsia
Copy link
Contributor Author

kyryl-perepelytsia commented Jun 12, 2024

looks great! thank you @kyryl-perepelytsia . I'll see if I can adjust the button gaps in a follow up

oh you already merged it, thanks!

Actually i am bit struggled with a positioning of this button.

The problem in dropdown that has absolute positioning, and with a sticky footer.

If i'm trying to apply relative position on some of a parent elements inside form (to make correct positioning of a button with dropdown), it will correctly place button, but there are other issues with dropdown(depends on what parent you adding relative position) :

  1. It starting to require scrolling down, as dropdown do not overlap footer (and its super non intuitive that button is in open state, as its hided under footer, and shows only after you scroll the parent DIV of a button)
  2. The dropdown also do not overlap footer, but the whole form starting to jump when you opening drop down

If do not apply relative position on a parent, then it will overlap submit button on a different screen resolutions.

What do you think maybe we can move this dropdown somewhere on a top of a form ?

@markphelps markphelps mentioned this pull request Jun 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants