-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to copy evaluate command in a CLI format #3154
feat: allow to copy evaluate command in a CLI format #3154
Conversation
Hey @kyryl-perepelytsia 👋 Thanks for the PR. Are you planning to push more up into this PR? |
65d8a7e
to
004d6d9
Compare
Signed-off-by: kyryl.perepelytsia <sooperkiras@gmail.com>
hey @GeorgeMac, sorry my bad, i have re-pushed all changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great on my end. 👏 Thank you @kyryl-perepelytsia
@all-contributors please add @kyryl-perepelytsia for code |
I've put up a pull request to add @kyryl-perepelytsia! 🎉 |
Works great @kyryl-perepelytsia ! Thank you for the PR! one minor bit of feedback, I think the spacing between the buttons is a bit off in the UI In 'desktop' view I feel like the spacing is too large between the button and the dropdown In mobile view there is some overlap. wdyt? |
Signed-off-by: kyryl.perepelytsia <sooperkiras@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
==========================================
+ Coverage 70.78% 71.59% +0.80%
==========================================
Files 91 109 +18
Lines 8729 7987 -742
==========================================
- Hits 6179 5718 -461
+ Misses 2165 1842 -323
- Partials 385 427 +42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thank you @kyryl-perepelytsia . I'll see if I can adjust the button gaps in a follow up
oh you already merged it, thanks! Actually i am bit struggled with a positioning of this button. The problem in dropdown that has absolute positioning, and with a sticky footer. If i'm trying to apply relative position on some of a parent elements inside form (to make correct positioning of a button with dropdown), it will correctly place button, but there are other issues with dropdown(depends on what parent you adding relative position) :
If do not apply relative position on a parent, then it will overlap submit button on a different screen resolutions. What do you think maybe we can move this dropdown somewhere on a top of a form ? |
Related to #2863