feat: support etag for declarative stores #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3287 +/- ##
==========================================
+ Coverage 64.12% 64.24% +0.11%
==========================================
Files 168 168
Lines 13392 13410 +18
==========================================
+ Hits 8588 8615 +27
+ Misses 4146 4137 -9
Partials 658 658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
related flipt-io#3248 Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
erka
force-pushed
the
etag-for-declarative-store
branch
from
8f6556b
to
57854e9
Compare
markphelps
reviewed
Jul 18, 2024
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
erka
force-pushed
the
etag-for-declarative-store
branch
from
d093dd4
to
460abc9
Compare
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
markphelps
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #3248