Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octave incorrectly labeled #8

Closed
elgow opened this issue Jul 22, 2020 · 2 comments
Closed

Octave incorrectly labeled #8

elgow opened this issue Jul 22, 2020 · 2 comments
Labels

Comments

@elgow
Copy link

elgow commented Jul 22, 2020

The keycap labels for the C keys are incorrect. The key labeled C3 sends a MIDI pitch of 60, which is C4 at a frequency of 261.63 Hz. Probably better to correctly label the octave, but apart from that nit it's a great and useful application.

@flit
Copy link
Owner

flit commented Jul 22, 2020

Thanks for the the report!

I think part of the issue is that the actual octave numbers are sometimes shifted, depending on where you look.

@flit flit added the bug label Jul 22, 2020
flit added a commit that referenced this issue Jan 30, 2021
@flit
Copy link
Owner

flit commented Feb 13, 2021

Closing this issue; it's fixed in version 1.9.1.

The history behind C3 vs C4 is actually quite interesting. It seems lot of MIDI related software actually lets you select which middle C octave to show in the UI. But I'm happy to go with the official MIDI notation. 🎹

@flit flit closed this as completed Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants