Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Nearby Riders snackbars are buggy #11

Closed
urmilshroff opened this issue Nov 2, 2019 · 2 comments
Closed

[BUG] Nearby Riders snackbars are buggy #11

urmilshroff opened this issue Nov 2, 2019 · 2 comments
Assignees
@urmilshroff
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@urmilshroff
Copy link
Member

urmilshroff commented Nov 2, 2019 •
edited
Loading

Describe the bug
Snackbar is displayed with random, incorrect info at times.

To reproduce
Steps to reproduce the behavior:

  1. Launch the app and swipe to mark location
  2. Snackbar will show n nearby Riders
  3. It will randomly update with n+1 or n-1 nearby Riders
  4. Then it will change again

Expected behavior
Snackbar should be displayed with correct info only when the number of nearby Riders actually change
@urmilshroff urmilshroff added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Nov 2, 2019
@urmilshroff urmilshroff reopened this Nov 11, 2019
@urmilshroff urmilshroff reopened this Nov 21, 2019
@urmilshroff urmilshroff changed the title [BUG] Nearby Riders snackbar needs work [BUG] Nearby Riders snackbars are buggy Nov 21, 2019
urmilshroff added a commit that referenced this issue Nov 24, 2019
@urmilshroff
Bug fixes and improvements (#11 possibly fixed)
1cc1f6a
@urmilshroff
Copy link
Member Author

@prince1998 we really need to work on fixing this once and for all

@urmilshroff urmilshroff reopened this Nov 29, 2019
urmilshroff added a commit that referenced this issue Dec 2, 2019
@urmilshroff
Narrowed down source of issue #11
3f90a34
urmilshroff added a commit that referenced this issue Dec 14, 2019
@urmilshroff
Improved #11
0fa219e
@urmilshroff
Copy link
Member Author

Practically impossible to fix this as it's an architecture/design flaw, not a minor coding issue. The whole app will need to be rewritten using a different state management technique such as BLoC.

@urmilshroff urmilshroff mentioned this issue Jan 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urmilshroff urmilshroff

Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@urmilshroff @prince1998 @vinay-ai