Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add esbuild bundler #240

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

mR4smussen
Copy link
Contributor

eventually this closes #70

This PR introduces esbuild as a project bundler. Esbuild is built on Go, allowing it to get extremely good compile times.
Also for the Flix extension to be used in a vscode web environments like github.dev and vscode.dev we will need to use a bundler, since vscode can only load a single file for an extension when running in a browser.

I wasn't quite sure of the best way to test this PR. When building the project, I get no errors (and I get the bundled client/out/extension.js file), and when launching the extension, it works like usual.

@magnus-madsen
Copy link
Member

Does this require one to have Go installed or does it work out of the box?

@mR4smussen
Copy link
Contributor Author

It works out of the box

@magnus-madsen
Copy link
Member

Ill take a look later today :)

Today you have time for a meeting next week?

@mR4smussen
Copy link
Contributor Author

you have time for a meeting next week?

Sure, let’s coordinate over Gitter

@magnus-madsen magnus-madsen merged commit 6de2bb4 into flix:master Jan 12, 2023
@magnus-madsen
Copy link
Member

It seems to work, but were not there yet, because I still see:

This extension consists of 3178 files, out of which 2824 are JavaScript files. For performance reasons, you should bundle your extension: https://aka.ms/vscode-bundle-extension . You should also exclude unnecessary files by adding them to your .vscodeignore: https://aka.ms/vscode-vscodeignore
 DONE  Packaged: X:\Work\GitHub\flix\vscode-flix\flix-0.88.0.vsix (3178 files, 3.26MB)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Bundler
2 participants